Skip to content

Update the release documentation#85370

Merged
flokli merged 1 commit intoNixOS:release-20.03from
immae:fix_acme_reuse_key_20_03
Apr 18, 2020
Merged

Update the release documentation#85370
flokli merged 1 commit intoNixOS:release-20.03from
immae:fix_acme_reuse_key_20_03

Conversation

@immae
Copy link
Contributor

@immae immae commented Apr 16, 2020

Motivation for this change

Partial backport of #85369

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@immae
Copy link
Contributor Author

immae commented Apr 16, 2020

cc @arianvp @emilazy @m1cr0man @aanderse @flokli

@immae immae mentioned this pull request Apr 16, 2020
Closed
4 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 16, 2020
@immae
Copy link
Contributor Author

immae commented Apr 16, 2020

The backport is only partial because the release branch and the master branch diverged, it might be worth backporting the other missing commits to complete this one

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 16, 2020
@arianvp
Copy link
Member

arianvp commented Apr 16, 2020

Thanks! also please put back the note about rollbacks here as well

arianvp
arianvp reviewed Apr 16, 2020
View reviewed changes
nixos/modules/security/acme.nix Outdated
Copy link
Member

@arianvp arianvp Apr 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also; please add this change's description to the commit as well. Now the commit only talks about doc improvements but there's also a functional change. (Or just leave it out? im not sure)

Copy link
Contributor Author

@immae immae Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll leave it out yes, it has no consequence to use this one or another in the current 20.03 code, since there is no way to pass --reuse-key. If it’s an option, I think it would be a good idea to backport the changes from unstable, since key pinning is striclty impossible currently

Copy link
Contributor Author

@immae immae Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(done)

@immae immae force-pushed the fix_acme_reuse_key_20_03 branch from 1d5a7cc to 60fb696 Compare April 16, 2020 13:01
@ofborg ofborg bot removed the 8.has: module (update) This PR changes an existing module in `nixos/` label Apr 16, 2020
@arianvp
Copy link
Member

arianvp commented Apr 17, 2020

cc @worldofpeace

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 17, 2020

Can we make the commit message specific #85366 (comment) rl-2003: ...

@immae
rl-2003: Update the release documentation
21c4a33 
It currently says that everything will be backward compatible between lego and simp-le certificates, but it’s not.
@immae immae force-pushed the fix_acme_reuse_key_20_03 branch from 60fb696 to 21c4a33 Compare April 17, 2020 20:20
@immae
Copy link
Contributor Author

immae commented Apr 17, 2020

Can we make the commit message specific #85366 (comment) rl-2003: ...

Changed @worldofpeace

@flokli
Copy link
Member

flokli commented Apr 18, 2020

Thanks!

@flokli flokli merged commit e79b7c4 into NixOS:release-20.03 Apr 18, 2020
@flokli flokli mentioned this pull request Apr 18, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arianvp arianvp arianvp left review comments

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@immae @arianvp @worldofpeace @flokli