Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: 1.8.1 -> 1.9.2 #84931

Merged
merged 1 commit into from
Apr 11, 2020
Merged

minikube: 1.8.1 -> 1.9.2 #84931

merged 1 commit into from
Apr 11, 2020

Conversation

ngerstle
Copy link
Contributor

Motivation for this change

I wanted to try the experimental multi-node minikube (kubernetes/minikube#6787), and noticed the minikube tool was a bit behind.
Figured a general update wouldn't hurt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 merged commit 3b15c63 into NixOS:master Apr 11, 2020
@ngerstle ngerstle deleted the update-minikube branch April 11, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants