Skip to content

ghc: do not use ld.gold with musl libc #84670#84741

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
adamse:haskell-updates
Apr 9, 2020
Merged

ghc: do not use ld.gold with musl libc #84670#84741
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
adamse:haskell-updates

Conversation

@adamse
Copy link
Contributor

@adamse adamse commented Apr 8, 2020 •
edited
Loading

Motivation for this change

Potential workaround for #84670.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adamse adamse requested a review from cdepillabout as a code owner April 8, 2020 18:05
@ofborg ofborg bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 8, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 8, 2020
@adamse adamse force-pushed the haskell-updates branch from cb77f4a to acfccf7 Compare April 8, 2020 18:16
@adamse adamse changed the title haskell: do not use ld.gold with musl libc #84670 ghc: do not use ld.gold with musl libc #84670 Apr 8, 2020
@cdepillabout
Copy link
Member

cdepillabout commented Apr 9, 2020

@GrahamcOfBorg build pkgsMusl.ghc

@cdepillabout
Copy link
Member

cdepillabout commented Apr 9, 2020

Looks like ofborg might have timed out.

@adamse Thanks for fixing this.

And thanks to @nh2 and @utdemir for reporting this.

@cdepillabout cdepillabout merged commit fcd35ef into NixOS:haskell-updates Apr 9, 2020
@cdepillabout cdepillabout mentioned this pull request Apr 9, 2020
Closed
@domenkozar
Copy link
Member

domenkozar commented Apr 9, 2020

I think we also need to backport to 20.03

@domenkozar
Copy link
Member

domenkozar commented Apr 9, 2020

Nitpick: would be nice to add a comment why musl is disabled

@adamse adamse mentioned this pull request Apr 9, 2020
Merged
@adamse
Copy link
Contributor Author

adamse commented Apr 9, 2020

Added a comment in #84809

@nh2 nh2 mentioned this pull request Apr 12, 2020
Open
@bb010g bb010g mentioned this pull request May 21, 2020
Open
@nh2
Copy link
Contributor

nh2 commented Jul 23, 2020 •
edited
Loading

Does this need a 20.03 backport still?

@nh2 nh2 mentioned this pull request Jul 23, 2020
Merged
10 tasks
@nh2
Copy link
Contributor

nh2 commented Jul 23, 2020

Does this need a 20.30 backport still?

Here: #93687

@ghost ghost mentioned this pull request Jul 25, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

1 more reviewer

@matthewbauer matthewbauer matthewbauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adamse @cdepillabout @domenkozar @nh2 @matthewbauer