Skip to content

Unbreak tensorflow haskell 1#84720

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
mikesperber:unbreak-tensorflow-haskell-1
Apr 9, 2020
Merged

Unbreak tensorflow haskell 1#84720
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
mikesperber:unbreak-tensorflow-haskell-1

Conversation

@mikesperber
Copy link
Contributor

Motivation for this change

haskellPackages.tensorflow is currently badly broken. I have things working, and will submit the associated pull requests successively. First, I need updates to the various dependencies - this is this pull request.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is the first step towards unbreaking the tensorflow packages.
@ofborg ofborg bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 8, 2020
@mikesperber mikesperber changed the base branch from master to haskell-updates April 8, 2020 13:53
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 8, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll continue to merge these PRs for you, but I'm worried about two things:

  1. The upstream tensorflow-haskell repo looks somewhat dead. There seem to be a bunch of useful PRs sitting around that no one is merging. There doesn't appear to be anyone working on updating tensorflow-haskell for tensorflow-1.15.
  2. I guess eventually nixpkgs will drop support for tensorflow-1? And at that point, tensorflow-haskell just won't be able to be compiled, unless it gets support for tensorflow-2?

If upstream doesn't merge your PRs in a timely manner, maybe you should just fork tensorflow-haskell? Maybe you'd be able to find a community of people willing to work on it?

Alternatively, I think there is already a good community around hasktorch, if you'd be interested in using that instead.

@cdepillabout cdepillabout merged commit 7029177 into NixOS:haskell-updates Apr 9, 2020
@mikesperber
Copy link
Contributor Author

Good points all. At the moment though, we're actively using it and I can take over maintenance for the next couple of months. (And I'm working on getting it going with Tensorflow 1.15.) If and when it dies, that'll be fine. But that's not yet.

@mikesperber
Copy link
Contributor Author

BTW, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants