haskellPackages.persistent-postgresql: don't check

[turboMaCk]

Disable tests for persistent-postgresql. Test suite now requires database.

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[kubaracek]

Had problem with this (that persistent-postgresql is running tests against an actual local database) 👍

[cdepillabout]

@turboMaCk persistent-postgresql is marked broken. Can you mark it unbroken?

https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968

This appears to build though, so it is fine to merge in after being marked unbroken.

[turboMaCk]

@cdepillabout are you sure it's marked as broken? I admit I had allowBroken = true in config before but after removing it this package seems to build. Also I don't see it in broken section of configuration-hackage2nix.yaml. Can you please check this again?

[cdepillabout]

@turboMaCk Unless I'm doing something wrong, I believe it is:

$ hub checkout https://github.com/NixOS/nixpkgs/pull/84272
From github.com:NixOS/nixpkgs
 * [new ref]                 refs/pull/84272/head -> persistent-postgresql
Switched to branch 'persistent-postgresql'
$ nix-build -A haskellPackages.persistent-postgresql
error: Package ‘persistent-postgresql-2.10.1.2’ in pkgs/development/haskell-modules/hackage-packages.nix:186837 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use '--show-trace' to show detailed location information)
$ git grep persistent-postgresql
...
pkgs/development/haskell-modules/configuration-hackage2nix.yaml:  - persistent-postgresql

[turboMaCk]

You're right sorry. Not sure why I missed it few moments ago. IRemoving allowBroken did not work for me because I had it already cached in nix-store on my machine but I must have missed the line in yaml.

[cdepillabout]

thanks for adding this comment as well

[cdepillabout]

Looks good, thanks!