Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] llvmPackages_10: init at 10.0.0 #84094

Merged
merged 1 commit into from
Apr 4, 2020
Merged

[20.03] llvmPackages_10: init at 10.0.0 #84094

merged 1 commit into from
Apr 4, 2020

Conversation

DieGoldeneEnte
Copy link
Contributor

Motivation for this change

Backport of llvmPackages_10 since Chromium 83 will depend on it.
See #83350 (comment)

@primeos Do we want to wait until Chromium 83 is released?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif @DieGoldeneEnte
llvmPackages_10: init at 10.0.0
28239c7 
Backport of llvmPackages_10 since Chromium 83 will depend on it.
See NixOS#83350 (comment)

llvmPackages_10: copy llvmPackages_9

* starting with rc2
* make `lldb` compilable again on Darwin
* separate out manpage creation for `lldb` into a new derivation
* minor tweaks to the patching of sources,
  some of which are backportable to earlier versions

(cherry picked from commit f111c6f)

llvmPackages_10: rc2 -> rc3

http://lists.llvm.org/pipermail/llvm-dev/2020-March/139729.html

Additionally cherry-picked 3 commits from `llvm-project/master`:
- llvm/llvm-project@d21664c
- llvm/llvm-project@3a0f6e6
- llvm/llvm-project@87dac7d

such that clang can automatically pick up the polly plugin from the
`llvm-polly` build.

(cherry picked from commit 3a84353)

llvmPackages_10: rc3 -> rc4

Only needed to update hashes and the version.
Updated comment for extension handling patch

(cherry picked from commit 0ec3f4e)

llvmPackages_10: removed extra polly-build

There is no good reason to have separate builds for polly and no-polly
versions. wwwwwThe reason for the two versions was (as far as I can
tell) to defer rebuilds (see ed60483).
Polly is now enabled by default.

(cherry picked from commit e9aa877)

llvmPackges_10: rc4 -> rc5

updated versino and hashes for new rc

(cherry picked from commit cdee144)

llvmPackages_10: rc5 -> release

updated hashes and url
updated comment regarding version/release_version to make it clearer

(cherry picked from commit 4665b2a)
@DieGoldeneEnte DieGoldeneEnte changed the title llvmPackages_10: init at 10.0.0 [20.03] llvmPackages_10: init at 10.0.0 Apr 2, 2020
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 2, 2020
@ofborg ofborg bot requested review from lovek323, 7c6f434c and dtzWill April 2, 2020 09:52
@primeos
Copy link
Member

primeos commented Apr 2, 2020

@GrahamcOfBorg build llvm_10

primeos
primeos approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff LGTM and the contents of pkgs/development/compilers/llvm/10 are indeed the same as on master.

As this only adds new attributes there is additionally no chance of any breakage so I see no problem with merging this PR right away.

@primeos Do we want to wait until Chromium 83 is released?

No need, it would actually best to merge this PR ASAP so that I can backport and test the required Chromium patches (including patches for some dependencies).

Edit: One thing I noticed is that you've already squashed all commits. AFAIK the normal approach would be to cherry-pick them individually, but since all original commit references are there I don't see any problems with this approach (it's probably cleaner anyway and I don't think we have any hard requirements regarding this - apart from the original commit references).

@primeos
Copy link
Member

primeos commented Apr 2, 2020

@NixOS/backports any objections? If not I'd assume that this is good to go (if the tests pass).

@primeos primeos merged commit 8532dd1 into NixOS:release-20.03 Apr 4, 2020
@primeos
Copy link
Member

primeos commented Apr 4, 2020

@DieGoldeneEnte thank you :)

@ggreif ggreif mentioned this pull request Apr 4, 2020
Merged
@worldofpeace
Copy link
Contributor

@primeos New packages are usually fine (especially if they're new versions of existing packages). As long as default versions don't change, that has much larger implications.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer matthewbauer is a code owner

@lovek323 lovek323 Awaiting requested review from lovek323

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DieGoldeneEnte @primeos @worldofpeace @rrbutani @ggreif