Skip to content

pythonPackages.quandl: 3.4.8 -> 3.5.0#83372

Merged
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-quandl-bump
Mar 27, 2020
Merged

pythonPackages.quandl: 3.4.8 -> 3.5.0#83372
jonringer merged 1 commit intoNixOS:masterfrom
drewrisinger:dr-pr-python-quandl-bump

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 25, 2020

Motivation for this change

Bump quandl version.

Format meta to match standard.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Found none.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

drewrisinger commented Mar 25, 2020

@GrahamcOfBorg build python27Packages.quandl python37Packages.quandl python38Packages.quandl

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 25, 2020
bhipple
bhipple requested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, but the CI build has failed.

jonringer
jonringer reviewed Mar 26, 2020
View reviewed changes
@drewrisinger
pythonPackages.quandl: 3.4.8 -> 3.5.0
80f2726 
Format meta to match standard practice.
@drewrisinger drewrisinger force-pushed the dr-pr-python-quandl-bump branch from 4ebb343 to 80f2726 Compare March 26, 2020 19:26
@drewrisinger drewrisinger requested a review from bhipple March 26, 2020 19:28
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Mar 26, 2020

@GrahamcOfBorg build python37Packages.quandl python38Packages.quandl

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Mar 26, 2020
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Mar 26, 2020

Output of nixpkgs-review pr 83372:

[2 built, 14 copied (8.8 MiB), 1.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83372
2 package built:
python37Packages.Quandl python38Packages.Quandl

@drewrisinger drewrisinger mentioned this pull request Mar 26, 2020
Merged
10 tasks
@drewrisinger drewrisinger requested a review from jonringer March 26, 2020 20:48
jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/83372
2 package built:
python37Packages.Quandl python38Packages.Quandl

@drewrisinger drewrisinger deleted the dr-pr-python-quandl-bump branch March 27, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@bhipple bhipple Awaiting requested review from bhipple

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drewrisinger @bhipple @jonringer