python3Packages.dipy: init at 1.1.1

[bcdarwin]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

cc @lheckemann @drewrisinger

[drewrisinger]

Don't know why I'm mentioned, but can you run some tests at least? Other than just import checks? Drew Risinger

…

On Wed, Mar 25, 2020 at 10:10 AM Ben Darwin ***@***.***> wrote: Motivation for this change Things done - Tested using sandboxing (nix.useSandbox <http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox> on NixOS, or option sandbox in nix.conf <http://nixos.org/nix/manual/#sec-conf-file> on non-NixOS linux) - Built on platform(s) - NixOS - macOS - other Linux distributions - [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests <https://github.com/NixOS/nixpkgs/blob/master/nixos/tests>) - [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" - Tested execution of all binary files (usually in ./result/bin/) - Determined the impact on package closure size (by running nix path-info -S before and after) - Ensured that relevant documentation is up to date - Fits CONTRIBUTING.md <https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md>. cc @lheckemann <https://github.com/lheckemann> @drewrisinger <https://github.com/drewrisinger> ------------------------------ You can view, comment on, or merge this pull request online at: #83359 Commit Summary - python3Packages.dipy: init at 1.1.1 File Changes - *A* pkgs/development/python-modules/dipy/default.nix <https://github.com/NixOS/nixpkgs/pull/83359/files#diff-4336360be21e2369d6c3a1a7d375d3e3> (83) - *M* pkgs/top-level/python-packages.nix <https://github.com/NixOS/nixpkgs/pull/83359/files#diff-2afbba83e1b14f9e0c304c769831a0e2> (2) Patch Links: - https://github.com/NixOS/nixpkgs/pull/83359.patch - https://github.com/NixOS/nixpkgs/pull/83359.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#83359>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNZYI26F46P6UWISOJMV7LRJIGD7ANCNFSM4LTPAMYQ> .

[bcdarwin]

The main issue is that the recommended way of running tests, dipy.test(), seems to run nose (which is unfortunately in the closure for some reason even though not required by the package) and then this hangs in multiprocessing.

[bcdarwin]

Just if you had any comments about how cvxpy is integrated here.

[drewrisinger]

Just if you had any comments about how cvxpy is integrated here.

Depends on if cvxpy is a hard requirement or optional. Seems fine if optional.

[wd15]

Built on non-nix linux

Result of nixpkgs-review pr 83359 1

2 package built:

• python37Packages.dipy
• python38Packages.dipy

[drewrisinger]

Would prefer to see some tests, even if fairly cursory. Do you get the multiprocessing hang in pytest? You said you did in nose.

[drewrisinger]

Would still like to see tests run, but builds as is currently.

[4 built, 6 copied (277.2 MiB), 62.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83359
2 package built:
python37Packages.dipy python38Packages.dipy

[jonringer]

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/83359
2 package built:
python37Packages.dipy python38Packages.dipy

[jonringer]

@GrahamcOfBorg build python37Packages.dipy python38Packages.dipy