Skip to content

nixos/sympa: fix outgoing emails, update package version#83258

Merged
infinisil merged 3 commits intoNixOS:masterfrom
mmilata:sympa-6.2.54
Apr 2, 2020
Merged

nixos/sympa: fix outgoing emails, update package version#83258
infinisil merged 3 commits intoNixOS:masterfrom
mmilata:sympa-6.2.54

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented Mar 24, 2020

Motivation for this change
  • The service has not been able to actually send emails because systemd sandboxing didn't allow it to call sendmail setgid wrapper. I probably broke it during the later iterations of sympa: init at 6.2.52 + NixOS module #65397 and haven't caught it until now. Shame on me.
  • New version contains various bugfixes, including CVE-2020-9369.
  • The --enable-fhs configure flag makes the resulting package layout saner, e.g. by not installing perl modules into $out/bin. Upstream plans to make this the default eventually.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmilata added 3 commits March 21, 2020 03:58
Update module accordingly.
Because ProtectKernelModules implies NoNewPrivileges, postfix's sendmail
executable, which is setgid, wasn't able to send mail.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 24, 2020
@ofborg ofborg bot requested a review from sorki March 24, 2020 01:51
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2020
@infinisil
Copy link
Member

@GrahamcOfBorg test sympa

@infinisil infinisil merged commit c06bcdd into NixOS:master Apr 2, 2020
@mmilata mmilata deleted the sympa-6.2.54 branch April 3, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants