lib/modules: Test the ability for config to depend on options for compatibility#82802
Merged
infinisil merged 1 commit intoNixOS:masterfrom Mar 18, 2020
Merged
Conversation
infinisil
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Prepare for a decentralized future with flakes, where modules will need to adapt to their neighbors, about which those modules can not make too many assumptions. Supporting two releases of NixOS may be impossible at times for flakes if they can't read the
optionsvariable.Additionally, this provides a partial solutions to the expression problem as applied to separately distributed modules.
Without this feature,
???will always have to be a separate module that users have to turn on manually to make the interaction betweenFeature AandFeature Bnot break.With this feature,
???can be packaged by eitherFlake AorFlake B, ensuring that the interaction between the features is always dealt with.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)