Skip to content

caprice32: 4.5.0 -> 4.6.0#82586

Closed
bignaux wants to merge 3 commits intoNixOS:masterfrom
bignaux:caprice32
Closed

caprice32: 4.5.0 -> 4.6.0#82586
bignaux wants to merge 3 commits intoNixOS:masterfrom
bignaux:caprice32

Conversation

@bignaux
Copy link

@bignaux bignaux commented Mar 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bignaux
Copy link
Author

bignaux commented Mar 14, 2020

@GrahamcOfBorg build caprice32

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 14, 2020
@alyssais
Copy link
Member

Can you squash the third commit into the first one please?

@bignaux
Copy link
Author

bignaux commented Mar 14, 2020

third commit into the first one please

it seems not the easiest to do, any idea how to do that , then #82183 to split in 3 a commit , i just want to save time to nixpkgs, i'm sometime a non believer how this is really helpfull when btw here we will have one commit for the merge stuff .

@alyssais
Copy link
Member

alyssais commented Mar 15, 2020 via email

@alyssais alyssais closed this Mar 15, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/branch-protection-policies/6410/14

@timokau
Copy link
Member

timokau commented Apr 1, 2020

@alyssais very cool, I love seeing somebody else's workflow. Very OT, but since this PR is merged its probably okay to abuse this thread a bit. How did you set up the fuzzy tab-completion like file search?

@alyssais
Copy link
Member

alyssais commented Apr 1, 2020 via email

@timokau
Copy link
Member

timokau commented Apr 1, 2020

Neat, I was already using fzf and its shell integrations but I was only aware of <C-R>. If anyone else is interested, here are all options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants