vimPlugins.coc-*: add npm dependencies#82578
Merged
adisbladis merged 3 commits intoNixOS:masterfrom Mar 15, 2020
Merged
Conversation
jonringer
reviewed
Mar 14, 2020
pkgs/misc/vim-plugins/overrides.nix
Outdated
Contributor
There was a problem hiding this comment.
apparently, this cannot be seen:
attribute 'coc-css' missing ... pkgs/misc/vim-plugins/overrides.nix:131:15
https://gist.github.com/GrahamcOfBorg/69f8e0bd962f1ce6fc88277a0d6fecce
Member
|
I'm not sure if any of the added extensions in this PR require this but can I suggest adding the $HOME fix to this commit as well: Considering that this commit also adds UPDATE: Oh, it's just been merged. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These plugins do not work, without having the npm package, as it needs to be build beforehand.
Things done
Added all the npm packages that exists for the plugins.
Small snippets used at the bottom.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Things used to generated this
Find all current packages
Output this to a file coc-vimplugins.txt.
OUtput to new file, then
cat coc-vimplugins-npm.txt | xargs -I "{}" echo ', "{}"', and add to node-packagesv10.json.Now override them all in vim-plugins-overrides.nix.
@adisbladis go go! ;)