junicode: update to 1.002 and correct license

[ivan-timokhin]

Motivation for this change

Update Junicode to the latest available version. Among other changes, Greek alphabet has been moved into a separate font, Foulis Greek, included alongside Junicode variants.

While at it, I have noticed that the license in the metadata doesn't match the one on the project site, and changed that as well.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
  The fonts at least look correct in fontforge.
• Determined the impact on package closure size (by running nix path-info -S before and after)
  Decreased from 3.0M to 2.2M
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.
  meta.maintainers is not set; other than that, I think everything fits.

[puzzlewolf]

Thanks for your first PR to Nixpkgs! The changes look good to me 👍

Would you consider adding yourself as a maintainer of this package? As you have already worked on it :)

[ivan-timokhin]

Would you consider adding yourself as a maintainer of this package? As you have already worked on it :)

I would personally prefer for the maintainer to be a bit more knowledgeable about the inner workings of the whole fontconfig thing, but I guess I can at least keep it up-to-date, so why not.

[puzzlewolf]

Thank you! LGTM 👍

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/134

[timokau]

Looks pretty good to me. My comments aren't really things you introduced, but its always nice to do some cleanup on the lines you're touching anyways.

[timokau]

In the spirit of NixOS/rfcs#35:

Suggested change

	name = "junicode-1.002";
	pname = "junicode";
	version = "1.002";

[timokau]

I just realized that this is using fetchzip, not mkDerivation. I'm not sure if the "name from pname and version" behaviour is implemented here. If it isn't, you additionally need to set

name = "${pname}-${version}";

[ivan-timokhin]

Not only doesn't it support ‘name from pname and version’, it actually gives me an error about unexpected argument ‘version’ in fetchurl if I try. So I let-bound them instead (following the example of agave.

[timokau]

Would you consider adding yourself as a maintainer of this package? As you have already worked on it :)

I would personally prefer for the maintainer to be a bit more knowledgeable about the inner workings of the whole fontconfig thing, but I guess I can at least keep it up-to-date, so why not.

The alternative here is no maintainer, so I'm glad you're willing to pick this up :) Also note that maintainership doesn't have to be exclusive, so if someone else wants to help out in the future they can add themselves too.

[timokau]

This should be two commits:

maintainers: add ivan-timokhin

and

junicode: add ivan-timokhin to maintainers

You can change this with an interactive rebase (git rebase -i, mark this commit as edit, split it into two commits). If you need more help with this, feel free to ask.

[ivan-timokhin]

Like this?

[timokau]

Perfect. Thank you and welcome to the team :)