Skip to content

users.groups.disnix instead of a list#81809

Merged
rnhmjoj merged 1 commit intoNixOS:masterfrom
dguibert:dg/disnix-group-list-to-attrset
Mar 5, 2020
Merged

users.groups.disnix instead of a list#81809
rnhmjoj merged 1 commit intoNixOS:masterfrom
dguibert:dg/disnix-group-list-to-attrset

Conversation

@dguibert
Copy link
Member

@dguibert dguibert commented Mar 5, 2020

related to #63103.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 5, 2020
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 5, 2020
@worldofpeace worldofpeace requested a review from rnhmjoj March 5, 2020 19:32
rnhmjoj
rnhmjoj approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@rnhmjoj rnhmjoj merged commit e64dcc2 into NixOS:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dguibert @rnhmjoj @worldofpeace