[20.03] nixos/initrd-network: always run postCommands#81744
Merged
Ma27 merged 2 commits intoNixOS:release-20.03from Mar 11, 2020
Merged
[20.03] nixos/initrd-network: always run postCommands#81744Ma27 merged 2 commits intoNixOS:release-20.03from
Ma27 merged 2 commits intoNixOS:release-20.03from
Conversation
As outlined in NixOS#71447, postCommands should always be run if networking in initrd is enabled. regardless if the configuration actually succeeded. (cherry picked from commit 5897899) The backport of this patch has been requested in NixOS#79532[1]. The diff is slightly off the original commit since some changes from ea7d024 were needed, however this commit shouldn't be backported as it potentially breaks existing setups. [1] NixOS#79532 (comment)
It seems as it takes a moment until the initrd-network is loaded. Please note that this is currently only reproducible on release-20.03.
Member
That would not really be intuitive, as you would now have to know the order in which things are executed in the initrd. 😐 |
Member
Author
I generally agree with you, but this is a backport PR with a bugfix and I don't think we should delay this backport (of already reviewed code) because of that. It's IMHO better to fix this on master first :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Please note that fffd09d was needed to fix the
initrd-network-ssh-test onrelease-20.03which is why I filed a PR.The backport of this patch has been requested in #79532[1]. The diff is
slightly off the original commit since some changes from
ea7d024 were needed, however this
commit shouldn't be backported as it potentially breaks existing setups.
[1] #79532 (comment)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)