Revert "defaultGemConfig: remove asciidoctor-diagram JARs"#81737
Merged
zimbatm merged 1 commit intoNixOS:masterfrom Mar 4, 2020
Merged
Revert "defaultGemConfig: remove asciidoctor-diagram JARs"#81737zimbatm merged 1 commit intoNixOS:masterfrom
zimbatm merged 1 commit intoNixOS:masterfrom
Conversation
This reverts commit 1ac11cc. asciidoctor-diagram starts Java processes, so the JARs are necessary on all platforms. See NixOS#77149 (comment).
alyssais
added
9.needs: port to stable
ofborg
bot
added
the
6.topic: ruby
nomeata
approved these changes
Mar 4, 2020
Contributor
nomeata
left a comment
nomeata
left a comment
There was a problem hiding this comment.
LGTM, brief local testing successful.
ofborg
bot
added
10.rebuild-darwin: 11-100
zimbatm
added a commit
that referenced
this pull request
Mar 4, 2020
This reverts commit 1ac11cc. asciidoctor-diagram starts Java processes, so the JARs are necessary on all platforms. See #77149 (comment). (cherry picked from commit 89a0945)
Member
|
also cherry-picked into 20.03 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1ac11cc.
asciidoctor-diagram starts Java processes, so the JARs are necessary
on all platforms.
See #77149 (comment).
@nomeata please test