Skip to content

fix folks package#81645

Closed
andir wants to merge 2 commits intoNixOS:masterfrom
andir:fix-folks
Closed

fix folks package#81645
andir wants to merge 2 commits intoNixOS:masterfrom
andir:fix-folks

Conversation

@andir
Copy link
Member

@andir andir commented Mar 3, 2020

Motivation for this change

This fixes the hydra build failure: https://hydra.nixos.org/build/113851386/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andir added 2 commits March 3, 2020 20:20
@andir andir requested review from callahad and worldofpeace March 3, 2020 19:22
@andir andir requested review from FRidh and jonringer as code owners March 3, 2020 19:22
@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 3, 2020
@ofborg ofborg bot requested review from hedning and jtojnar March 3, 2020 19:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 3, 2020
@jtojnar
Copy link
Member

jtojnar commented Mar 3, 2020

See also #81616

@andir
Copy link
Member Author

andir commented Mar 3, 2020

Oh, that didn't show up as a good hit when searching for "folks".

@worldofpeace
Copy link
Contributor

I think I'd prefer to merge @jtojnar PR, it fixes up a few more things at once.

@jtojnar jtojnar closed this Mar 3, 2020
@worldofpeace
Copy link
Contributor

Oh, that didn't show up as a good hit when searching for "folks".

Yeah, it was not initially apparent. But I guess it was discovered whilst updating gom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants