Skip to content

Pipewire 0.3.0#81384

Closed
worldofpeace wants to merge 2 commits intoNixOS:masterfrom
worldofpeace:pipewire-3.0
Closed

Pipewire 0.3.0#81384
worldofpeace wants to merge 2 commits intoNixOS:masterfrom
worldofpeace:pipewire-3.0

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Feb 29, 2020

Motivation for this change

Mutter 3.36 will depend on this https://gitlab.gnome.org/GNOME/mutter/-/blob/84275688f32b1a15a2cb60447ecbf75b526c164a/meson.build#L53

This is a draft because merging this will break stuff until other releases have been made.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from hedning February 29, 2020 16:19
worldofpeace
worldofpeace commented Feb 29, 2020
View reviewed changes
pkgs/development/libraries/pipewire/default.nix

outputs = [ "out" "lib" "dev" "doc" ];
patches = [
# https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/235
Copy link
Contributor Author

@worldofpeace worldofpeace Feb 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened this patch so we don't have to do

PKG_CONFIG_SYSTEMD_SYSTEMDUSERUNITDIR = "${placeholder "out"}/lib/systemd/user";

@worldofpeace worldofpeace changed the title Pipewire 3.0 Pipewire 0.3.0 Feb 29, 2020
@ofborg ofborg bot requested a review from jtojnar February 29, 2020 16:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 29, 2020
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Mar 3, 2020

Closing because it's dependent on gnome 3.36, it's integrated into #81626

@jtojnar jtojnar deleted the pipewire-3.0 branch April 8, 2020 15:33
@jtojnar jtojnar restored the pipewire-3.0 branch April 8, 2020 15:34
@jtojnar jtojnar reopened this Apr 8, 2020
@jtojnar jtojnar marked this pull request as ready for review April 8, 2020 15:34
@jtojnar jtojnar closed this Apr 8, 2020
@jtojnar jtojnar deleted the pipewire-3.0 branch April 8, 2020 15:35
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@worldofpeace @jtojnar