Skip to content

R: Update R, CRAN, & Bioconductor#81307

Merged
peti merged 1 commit intoNixOS:masterfrom
jabranham:r-pkgs
Apr 17, 2020
Merged

R: Update R, CRAN, & Bioconductor#81307
peti merged 1 commit intoNixOS:masterfrom
jabranham:r-pkgs

Conversation

@jabranham
Copy link
Contributor

Motivation for this change

Update R packages @peti

Things done

Checked the expression evaluates using nix-build test-evaluation.nix --dry-run

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jabranham jabranham requested a review from peti as a code owner February 28, 2020 17:32
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 28, 2020
@jabranham jabranham changed the title R: Update CRAN & Bioconductor R: Update R, CRAN, & Bioconductor Mar 10, 2020
@jabranham
Copy link
Contributor Author

Added a commit to update R along with its packages @peti

@ofborg ofborg bot requested a review from timokau March 10, 2020 23:27
@timsears timsears mentioned this pull request Mar 21, 2020
10 tasks
@jabranham
Copy link
Contributor Author

@peti or @timokau Can we merge this?

@timokau
Copy link
Member

timokau commented Mar 30, 2020

I have never touched those package sets, so I'll defer to @peti.

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates. Assuming that all goes well, I'll merge ASAP.

@jabranham
Copy link
Contributor Author

Hydra build finished, looks OK to me.

@peti
Copy link
Member

peti commented Apr 3, 2020

The update introduces lots of evaluation errors: https://hydra.nixos.org/jobset/nixpkgs/r-updates#tabs-errors. We can't merge it in that state.

@peti
Copy link
Member

peti commented Apr 8, 2020

@jabranham, will you do anything about those evaluation errors?

@jabranham
Copy link
Contributor Author

@peti Sorry, missed that notification somehow. I updated the package sets to today and fixed the evaluation errors, hopefully.

@peti
Copy link
Member

peti commented Apr 10, 2020

I re-started Hydra ...

@peti peti merged commit 464d186 into NixOS:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants