Merged
Conversation
Contributor
Author
|
Added a commit to update R along with its packages @peti |
10 tasks
Contributor
Author
Member
|
I have never touched those package sets, so I'll defer to @peti. |
peti
reviewed
Apr 1, 2020
Member
peti
left a comment
There was a problem hiding this comment.
Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates. Assuming that all goes well, I'll merge ASAP.
4 tasks
Contributor
Author
|
Hydra build finished, looks OK to me. |
Member
|
The update introduces lots of evaluation errors: https://hydra.nixos.org/jobset/nixpkgs/r-updates#tabs-errors. We can't merge it in that state. |
4 tasks
Member
|
@jabranham, will you do anything about those evaluation errors? |
Contributor
Author
|
@peti Sorry, missed that notification somehow. I updated the package sets to today and fixed the evaluation errors, hopefully. |
Member
|
I re-started Hydra ... |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update R packages @peti
Things done
Checked the expression evaluates using
nix-build test-evaluation.nix --dry-runsandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)