Skip to content

Comments

darwin: fix NIX_LDFLAGS usages#80890

Merged
LnL7 merged 2 commits intoNixOS:release-20.03from
LnL7:darwin-ldflags
Apr 3, 2020
Merged

darwin: fix NIX_LDFLAGS usages#80890
LnL7 merged 2 commits intoNixOS:release-20.03from
LnL7:darwin-ldflags

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 23, 2020

Motivation for this change

Backport of #80603 and #80635.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 requested a review from Profpatsch as a code owner February 23, 2020 12:10
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 23, 2020
@ofborg ofborg bot requested a review from mboes February 23, 2020 12:25
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 23, 2020
@worldofpeace worldofpeace added the 8.has: port to stable This PR already has a backport to the stable release. label Feb 23, 2020
@LnL7 LnL7 mentioned this pull request Mar 28, 2020
Merged
10 tasks
eraserhd and others added 2 commits April 3, 2020 22:27
@eraserhd @LnL7
plan9port: fix linker flags for macosx
6693266 
(cherry picked from commit 4d2a825)
(cherry picked from commit 7724ef7)
@marsam @LnL7
bazel: fix linker flags for darwin
f941714 
(cherry picked from commit d1ee615)
@LnL7 LnL7 force-pushed the darwin-ldflags branch from 2e6459d to f941714 Compare April 3, 2020 20:27
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Apr 3, 2020
@LnL7 LnL7 merged commit 1c32029 into NixOS:release-20.03 Apr 3, 2020
@LnL7 LnL7 deleted the darwin-ldflags branch April 3, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@mboes mboes Awaiting requested review from mboes

1 more reviewer

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LnL7 @worldofpeace @eraserhd @marsam