spago: fix Darwin build#80459
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Feb 19, 2020
Merged
Conversation
This change gets round a weird permissions error on darwin
Member
|
Seems like a reasonable workaround. Thanks for taking a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As noted earlier, Spago is currently broken for Darwin. This fixes that.
It's a weird issue. The problem is that when doing a
fileEmbedof the content downloaded at build time, read permissions are insufficient.dtrussconfirms that ghc requests write permissions when callingopen.I don't understand why this should happen, but all the static files in the same
templatesdirectory have permissions0644, and making it the same for the two separately downloaded files seems benign enough as a workaround. Once the build is complete, it all gets deleted anyway.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)