Skip to content

crystal: 0.32.1 -> 0.33.0#80390

Closed
Br1ght0ne wants to merge 3 commits intoNixOS:masterfrom
Br1ght0ne:crystal-0.33.0
Closed

crystal: 0.32.1 -> 0.33.0#80390
Br1ght0ne wants to merge 3 commits intoNixOS:masterfrom
Br1ght0ne:crystal-0.33.0

Conversation

@Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Feb 18, 2020 •
edited
Loading

Motivation for this change

ZHF: #80379
Can't be backported to 20.03 because of feature freeze (0.32.1 build for 20.03 handled in #80389)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from davy-tw, manveru and peterhoeg February 18, 2020 00:16
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 18, 2020
@Br1ght0ne Br1ght0ne mentioned this pull request Feb 18, 2020
Merged
1 task
@Br1ght0ne Br1ght0ne force-pushed the crystal-0.33.0 branch 2 times, most recently from 7c9d724 to 525129e Compare February 18, 2020 00:45
@Br1ght0ne Br1ght0ne marked this pull request as ready for review February 18, 2020 00:46
@Br1ght0ne
Copy link
Member Author

Br1ght0ne commented Feb 18, 2020 •
edited
Loading

Sorry, accidentally committed a (now revoked) secret.

@Br1ght0ne
Copy link
Member Author

Br1ght0ne commented Feb 18, 2020 •
edited
Loading

Skipped a broken test, see crystal-lang/crystal#7925
@GrahamcOfBorg build crystal

lukateras
lukateras approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, compiler is working.

pkgs/development/compilers/crystal/default.nix

makeFlags = [
"CRYSTAL_CONFIG_VERSION=${version}"
# FIXME: not sure if this is the best idea
Copy link
Member

@lukateras lukateras Feb 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? LGTM. The alternative is to set a writable HOME.

@peterhoeg @lukateras
Update pkgs/development/compilers/crystal/default.nix
a0dae99 
Co-Authored-By: Yegor Timoshenko <yegortimoshenko@riseup.net>
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 23, 2020
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 23, 2020
@lukateras
Copy link
Member

lukateras commented Feb 23, 2020 •
edited
Loading

Will merge on Feb 25 12 pm UTC unless anyone minds otherwise.

@lukateras
Copy link
Member

lukateras commented Feb 27, 2020

@GrahamcOfBorg build crystal_0_32

@lukateras
Copy link
Member

lukateras commented Feb 27, 2020

Unfortunately, looks like changes to generic break crystal_0_32_0 build :(

@lukateras lukateras self-requested a review February 27, 2020 03:58
@peterhoeg
Copy link
Member

peterhoeg commented Apr 19, 2020

Superseded by #85432

@peterhoeg peterhoeg closed this Apr 19, 2020
@Br1ght0ne Br1ght0ne deleted the crystal-0.33.0 branch April 23, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@manveru manveru Awaiting requested review from manveru

@davy-tw davy-tw Awaiting requested review from davy-tw

@lukateras lukateras Awaiting requested review from lukateras

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Br1ght0ne @lukateras @peterhoeg