Closed
Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
disassembler
force-pushed
the
pin-nodejs-12
branch
from
3f10a36 to
a2ffd56
Compare
Member
Author
|
This is not going in release 20.03. It will be part of 20.09. |
ofborg
bot
added
10.rebuild-darwin: 101-500
Contributor
|
I think we should also make |
raboof
reviewed
Apr 11, 2020
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Some comments, and it seems this PR has a merge conflict so needs a rebase.
| {pkgs ? import <nixpkgs> { | ||
| inherit system; | ||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}: | ||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}: |
| }; | ||
| }; | ||
| "caniuse-lite-1.0.30001025" = { | ||
| "caniuse-lite-1.0.30001027" = { |
Member
There was a problem hiding this comment.
Are these changes relevant here?
| nixnote2 = libsForQt5.callPackage ../applications/misc/nixnote2 { }; | ||
|
|
||
| nodejs = hiPrio nodejs-10_x; | ||
| nodejs = hiPrio nodejs-12_x; |
Member
There was a problem hiding this comment.
👍 I would like this, too. Perhaps also update nodejs-slim?
Member
|
Seems this is superseded by #85764 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)