Skip to content

nixos: fix bunch of mangled usernames#79747

Merged
rnhmjoj merged 3 commits intoNixOS:masterfrom
mmilata:fix-mangled-usernames
Feb 10, 2020
Merged

nixos: fix bunch of mangled usernames#79747
rnhmjoj merged 3 commits intoNixOS:masterfrom
mmilata:fix-mangled-usernames

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented Feb 10, 2020 •
edited
Loading

Motivation for this change

Fix what looks like regex-went-wrong @ 1d61efb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @rnhmjoj #63103

@mmilata mmilata requested a review from rnhmjoj February 10, 2020 17:02
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 10, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 10, 2020

Indeed, I used a Vim macro at some point and must have messed up.
Sorry for the trouble caused, but as you can imagine reviewing all those changes is pretty tough. Thank you for the fix!

@rnhmjoj rnhmjoj merged commit 019b637 into NixOS:master Feb 10, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 10, 2020
@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 10, 2020

Thanks for this 👍

@mmilata mmilata deleted the fix-mangled-usernames branch February 10, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmilata @rnhmjoj @worldofpeace