doc: python: fixing mistake in venv example#78953
Merged
jonringer merged 1 commit intoNixOS:masterfrom Feb 2, 2020
Merged
Conversation
ofborg
bot
added
8.has: documentation
rnhmjoj
reviewed
Feb 1, 2020
jonringer
approved these changes
Feb 2, 2020
Contributor
jonringer
left a comment
jonringer
left a comment
There was a problem hiding this comment.
LGTM, once comment gets resolved
When updating the section to python 3 some places still referred to pythonPackages and were overlooked. Decided to switch it to be more similar to the first example binding pythonPackages and clarified comments a bit based on confusion I observed on IRC. Related to NixOS#77569
d-goldin
force-pushed
the
python_doc_venv_2
branch
from
612ea9a to
a9d5dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating the section to python 3 some places still referred to pythonPackages and were overlooked.
Decided to switch it to be more similar to the first example binding pythonPackages and clarified comments a bit based on confusion I observed on IRC.
Related to #77569
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@FRidh @jonringer