vimPlugins.vim-instant-markdown: init at 2019-09-06#78579
vimPlugins.vim-instant-markdown: init at 2019-09-06#78579iv-nn wants to merge 3 commits intoNixOS:masterfrom
Conversation
jonringer
left a comment
There was a problem hiding this comment.
this looks like an addition of a node package, and usage of said package in a vim module. The commit history should look like:
nodePackages.instant-markdown-d: init at XXXXX
vimPlugins: update
vimPlugins.vim-instant-markdown: init at 2019-09-06
07015f5 to
743aaed
Compare
743aaed to
4df4919
Compare
|
I just rebased to fix conflicts. |
|
I just merged another big PR, do you mind rebasing again |
4df4919 to
338154d
Compare
|
Done. |
338154d to
f058745
Compare
|
@GrahamcOfBorg eval |
f058745 to
93b4f2a
Compare
|
I finally got to rebase it, had issue with the node packages |
|
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
93b4f2a to
473cad4
Compare
473cad4 to
e92d651
Compare
|
@iv-nn It's a hassle with the constant merge conflicts :( but are you still available for seeing this through to the end 🚀 ? Otherwise I'd just pick it up |
|
usually the conflicts aren't too bad with vim plugins, but they are horrendous with node, as it needs to re-make the entire node world. |
|
I tried to rebase and run |
|
I marked this as stale due to inactivity. → More info |
|
@iv-nn place yourself on top of master, cherry-pick the code that hasn't changed and redo what you've done the first time. I can try to merge it quick if that works fine. |
|
feel free to reopen when rebasing/updating the PR |
Motivation for this change
Add vim-instant-markdown plugin.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)