Skip to content

nodePackages.clubhouse-cli: init at 2.1.0#77705

Closed
tobim wants to merge 2 commits intoNixOS:masterfrom
tobim:nodePackages/clubhouse-cli
Closed

nodePackages.clubhouse-cli: init at 2.1.0#77705
tobim wants to merge 2 commits intoNixOS:masterfrom
tobim:nodePackages/clubhouse-cli

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Jan 14, 2020

Motivation for this change

I'm using this at work.
https://github.com/andjosh/clubhouse-cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tobim
tobim commented Jan 14, 2020
View reviewed changes
pkgs/development/node-packages/node-env.nix
npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild

if [ "''${dontNpmInstall-}" != "1" ]
if [ "$dontNpmInstall" != "1" ]
Copy link
Contributor Author

@tobim tobim Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was done by the script. I'm not sure this is OK.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 14, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@prusnak prusnak added 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels May 30, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@cideM cideM mentioned this pull request Oct 15, 2020
Merged
10 tasks
@ryantm
Copy link
Member

ryantm commented Oct 16, 2020

merged via #100606

@ryantm ryantm closed this Oct 16, 2020
@dotlambda dotlambda mentioned this pull request Aug 18, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobim @prusnak @ryantm