Skip to content

libxml2: don't propagate Python bindings#77474

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:libxml2
Jan 13, 2020
Merged

libxml2: don't propagate Python bindings#77474
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:libxml2

Conversation

@alyssais
Copy link
Member

Motivation for this change

Extracted from #77149. Quoting myself there:

I suspect there will be packages that relied on the libxml2 Python
bindings being propagated, but don't know how I'd identify them. The
libxml2 change is too big for nix-review to handle. Any ideas?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Jan 10, 2020
@ofborg ofborg bot requested a review from edolstra January 10, 2020 22:12
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 10, 2020
@FRidh FRidh self-assigned this Jan 11, 2020
@FRidh FRidh added the 6.topic: closure size The final size of a derivation, including its dependencies label Jan 11, 2020
@FRidh
Copy link
Member

FRidh commented Jan 11, 2020

This has existed since about 2015, 38313d5, which was when multiple outputs was introduced (#7701).

Nowadays the Python bindings are in python-packages.nix and packages should use those. Not all of them work that way though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the docs are correct, we should not need this line at all:

propagatedBuildOutputs of that package which by default contain $outputBin and $outputLib

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that is still he case:

local po_dirty="$outputBin $outputInclude $outputLib"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed the whole line on master and was able to build a few hundred packages fine :)

@alyssais
Copy link
Member Author

Okay then. Here we go!

I guess the staging process would pick up if this did cause catastrophic breakage anyway.

@alyssais alyssais merged commit 863fc65 into NixOS:staging Jan 13, 2020
@alyssais alyssais deleted the libxml2 branch March 4, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: closure size The final size of a derivation, including its dependencies 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

Comments