nixos/matrix-synapse, nixos/mxisd: fix empty usernames#77344
Merged
worldofpeace merged 2 commits intoNixOS:masterfrom Jan 9, 2020
Merged
nixos/matrix-synapse, nixos/mxisd: fix empty usernames#77344worldofpeace merged 2 commits intoNixOS:masterfrom
worldofpeace merged 2 commits intoNixOS:masterfrom
Conversation
ghost
approved these changes
Jan 9, 2020
Contributor
|
Thanks @bachp |
Contributor
|
For ref the issue is #77189. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It appears #77177 accidently sets the username of the
matrix-synapseuser to "" (emtpy).This causes the service fail.
I havent' tested the
mxisdservice but it seems it will have the same issue, so a fix is also includedThings done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @petabyteboy @worldofpeace