Skip to content

vagrant: Resolve crash by replacing gem symlinks with directories#76765

Merged
Mic92 merged 2 commits intoNixOS:masterfrom
andersk:vagrant-nameerror
Jan 6, 2020
Merged

vagrant: Resolve crash by replacing gem symlinks with directories#76765
Mic92 merged 2 commits intoNixOS:masterfrom
andersk:vagrant-nameerror

Conversation

@andersk
Copy link
Contributor

@andersk andersk commented Jan 1, 2020

Motivation for this change

This workaround was discovered by painstakingly resolving the differences between a working installation and a non-working installation until a minimal change was found. I have no idea why it works.

Fixes #76629.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aneeshusa

This workaround was discovered by painstakingly resolving the
differences between a working installation and a non-working
installation until a minimal change was found.  I have no idea why it
works.

Fixes NixOS#76629.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Just running `vagrant --version` was insufficient to catch NixOS#76629, but
this would have.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 1, 2020
@Mic92 Mic92 merged commit 7178637 into NixOS:master Jan 6, 2020
@happy-river happy-river mentioned this pull request Jan 30, 2020
12 tasks
@andersk andersk deleted the vagrant-nameerror branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vagrant broken by rubygems 3.1.2 upgrade: uninitialized constant I18n::Config (NameError)

2 participants