nixos/haskell: Added option to the haskell mkDerivation to build quickjump index#75939
Closed
mgttlinger wants to merge 147 commits intoNixOS:haskell-updatesfrom
Closed
nixos/haskell: Added option to the haskell mkDerivation to build quickjump index#75939mgttlinger wants to merge 147 commits intoNixOS:haskell-updatesfrom
mgttlinger wants to merge 147 commits intoNixOS:haskell-updatesfrom
Conversation
ofborg
bot
added
6.topic: haskell
Member
|
@mgttlinger Thanks for this new feature. This will definitely come in handy. Can you rebase this on the I think this looks good, but I am somewhat worried about turning it on for all packages. I have a hazy memory that I've seen quickjump indexes turned off because of some problem with Could you try to build all of our non-broken Haskell packages and see if you can find any that break? I have a script here that can be used to build the reverse dependencies of any package. You should be able to easily(?) adapt this script to try to build all the non-broken Haskell packages. If nothing breaks, then I'd be okay with merging this as-is. Alternatively, you could set it to Maybe @peti is willing to create a build on hydra for this branch and see what (if anything) breaks? |
Adding empty variables can lead to this problem:
```diff
wrapProgram \
./pye_menu_shell \
--prefix PATH : /nix/store/4c3z5r6yxsf2cxwwyazhdn92xixn4j5b-python3-3.7.5/bin:/nix/store/b3l3niilvqcxcsbxmd6sgqk1dy1rk81c-pye-menu-1.0/bin:/nix/store/y8j1cfj8d9r5rbbxc22w7hnfjw5f4fd3-cairo-1.16.0-dev/bin:/nix/store/6mg7lfbdh9pgx7pbxr3544qqbrigdl1q-freetype-2.10.1-dev/bin:/nix/store/gpszqcy0xi0lavbbjdq82zkkjp3jbp2a-bzip2-1.0.6.0.1-bin/bin:/nix/store/031c5pk5lzabgmpqpyd46hzi625as6bp-libpng-apng-1.6.37-dev/bin:/nix/store/f8kl7kmpv130aw9zm542p74a3hg0yc13-fontconfig-2.12.6-bin/bin:/nix/store/bqp30vkncmm222mjvwggz0s7p318sflj-expat-2.2.7-dev/bin:/nix/store/w57xa8g4s4aviwmqwgra7m5hwj2b005m-glib-2.60.7-dev/bin:/nix/store/v5d4966ahvfir2hwpv003022f3pb7vik-gettext-0.19.8.1/bin:/nix/store/qpvxhl1jr0fxnrx9idnpdagqs00m5m2z-glib-2.60.7/bin \
--set PYTHONNOUSERSITE true \
--set GDK_PIXBUF_MODULE_FILE /nix/store/7ddlakx6xjczqbfs80xjd14f30fzadws-gdk-pixbuf-2.38.1/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache \
--prefix XDG_DATA_DIRS : /nix/store/0snjc1qg89zqn3v35l9d55xrykh9nj5c-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10:/nix/store/b41z51vdv11n6df8ki5vj8dynxw98f9l-gsettings-desktop-schemas-3.32.0/share/gsettings-schemas/gsettings-desktop-schemas-3.32.0:/nix/store/0snjc1qg89zqn3v35l9d55xrykh9nj5c-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10 \
- --prefix GST_PLUGIN_SYSTEM_PATH_1_0 : \
+ --prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "" \
--prefix GI_TYPELIB_PATH : /nix/store/0snjc1qg89zqn3v35l9d55xrykh9nj5c-gtk+3-3.24.10/lib/girepository-1.0:/nix/store/z29l5xaaxh1s0697mcldj71ab0zshry1-librsvg-2.44.15/lib/girepository-1.0:/nix/store/pija1xzm7izxfb5m2hvhvlwp1l38ffxa-gobject-introspection-1.60.2/lib/girepository-1.0 \
- --prefix GRL_PLUGIN_PATH :
+ --prefix GRL_PLUGIN_PATH : ""
```
Where the diff is to highlight the problem: we don't have a valid value
for GST_PLUGIN_SYSTEM_PATH_1_0 or GRL_PLUGIN_PATH, and instead of
passing the empy string, the empty string gets unquoted somewhere, so we
end up passing no arguments, thus the parser in wrapProgram takes
--prefix as the argument of GST_PLUGIN_SYSTEM_PATH_1_0, and then
GI_TYPELIB_PATH is missing it's --prefix so wrapProgram complains/dies.
The easiest change is to not add empty arguments to the wrapper
Necessary for nfs server with kerberos auth
This is necessary for id mapping to work with NFS + Kerberos, and also touches NixOS#68106 and 634638.
A patch is necessary upstream to support multiple configs via symlinks in /etc/request-key.d Once that is done, we can add support for CIFS as well
* openh264: 1.8.0 -> 2.0.0 Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openh264/versions
Also gave the expression some love
When visiting local documentation via hoogle currently for most packages the quickjump index is missing so you only get a sad error when pressing "s" to search in the current documentation.
mgttlinger
force-pushed
the
hoogle-quickjump
branch
from
45e80fd to
9a896dd
Compare
mgttlinger
requested review from
Ericson2314,
FRidh,
jonringer,
nbp and
ttuegel
as code owners
Member
Author
|
Whoops I guess I messed up that rebase. Sorry for the spam. |
ofborg
bot
added
6.topic: GNOME
Member
Author
|
I'm gonna close and open a new PR instead of fixing this. |
10 tasks
Contributor
|
it's common when doing a base branch switch that the delay between you pushing and the setting the new base branch causes all the divergent commits to show up. :( |
Member
Author
|
@jonringer Ah I see. Nonetheless this continues in #75942 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When visiting local documentation via hoogle, currently for most packages the quickjump index is missing so you only get a sad error when pressing "s" to search in the current documentation.
Things done
Tested building my sytem including
pandoc,xmonad,xmonad-contrib(and all their deps) from the new tree andchecked that now quickjump works.sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)