Skip to content

Fix haskell-src-meta patch URI#75594

Closed
dfordivam wants to merge 1 commit intoNixOS:masterfrom
dfordivam:patch-1
Closed

Fix haskell-src-meta patch URI#75594
dfordivam wants to merge 1 commit intoNixOS:masterfrom
dfordivam:patch-1

Conversation

@dfordivam
Copy link
Copy Markdown
Contributor

@dfordivam dfordivam commented Dec 13, 2019

Motivation for this change

The current URI is not available anymore, this commit just points to the correct file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 13, 2019
@peti
Copy link
Copy Markdown
Member

peti commented Dec 13, 2019

@GrahamcOfBorg haskell.packages.ghc881.haskell-src-meta

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Dec 13, 2019

@dfordivam The reason these patches are using /master/ instead of an actual commit to the patch file is so that we can easily(?) figure out when the patch is no longer needed.

When an updated version of the upstream package is released to Hackage, then the patch gets deleted from head.hackage.

This is a sign for us to drop the patch.

In this case, it appears that a new release of haskell-src-meta has been made that supports ghc-8.8.1, so we no longer need this patch.

Can you update this PR to just drop the patch?

peti added a commit that referenced this pull request Dec 13, 2019
@peti
haskell-src-meta: update ghc-8.8.x build to the latest version
30c033c 
This allows us to build the package without the need for
patching. The test suite still doesn't compile unfortunately.

Closes #75594.
@peti
Copy link
Copy Markdown
Member

peti commented Dec 13, 2019

Fixed in 30c033c.

@peti peti closed this Dec 13, 2019
peti added a commit that referenced this pull request Dec 13, 2019
@peti
haskell-src-meta: update ghc-8.8.x build to the latest version
9c01e12 
This allows us to build the package without the need for
patching. The test suite still doesn't compile unfortunately.

Closes #75594.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dfordivam @peti @cdepillabout