Skip to content

hprotoc: fix broken build#75473

Closed
braydenjw wants to merge 1 commit intoNixOS:masterfrom
braydenjw:hprotoc-updates
Closed

hprotoc: fix broken build#75473
braydenjw wants to merge 1 commit intoNixOS:masterfrom
braydenjw:hprotoc-updates

Conversation

@braydenjw
Copy link
Copy Markdown
Contributor

@braydenjw braydenjw commented Dec 11, 2019

Motivation for this change

hprotoc haskell package marked as broken.

Things done

changed dependencies of hprotoc to protocol-buffers_2_4_13

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 11, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 11, 2019
cdepillabout
cdepillabout reviewed Dec 11, 2019
View reviewed changes
pkgs/development/haskell-modules/configuration-hackage2nix.yaml
- hp2pretty ==0.9
- hpack ==0.31.2
- hpack-dhall ==0.5.2
- hprotoc ==2.4.13
Copy link
Copy Markdown
Member

@cdepillabout cdepillabout Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #75449 (comment).

You'll have to create overrides for hprotoc versions in configuration-common.nix (and protocol-buffers-descriptor_2_4_13).

Also, please don't edit the hackage-packages.nix file. This is generated automatically by peti.

cdepillabout
cdepillabout requested changes Dec 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

@peti peti added the 9.needs: clean-up Somebody please clean up this mess! label Dec 18, 2019
peti
peti reviewed Dec 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you address https://github.com/NixOS/nixpkgs/pull/75473/files#r356387583?

@braydenjw
Copy link
Copy Markdown
Contributor Author

braydenjw commented Dec 18, 2019

Yes, I'm working on it!

I'm pretty new to Nix and NixOS, so it takes me a bit longer.

@peti
Copy link
Copy Markdown
Member

peti commented Jan 5, 2020

Please feel free to re-submit this fix once the changes suggested by the reviewers have been addressed.

@peti peti closed this Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peti peti peti left review comments

@cdepillabout cdepillabout cdepillabout requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 9.needs: clean-up Somebody please clean up this mess! 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@braydenjw @peti @cdepillabout @conaironvhs