Skip to content

Unbreak haskellPackages.clay#75446

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
turion:haskell-updates
Dec 11, 2019
Merged

Unbreak haskellPackages.clay#75446
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
turion:haskell-updates

Conversation

@turion
Copy link
Copy Markdown
Contributor

@turion turion commented Dec 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 10, 2019
@turion
Copy link
Copy Markdown
Contributor Author

turion commented Dec 10, 2019

I hope that this is roughly what is expected. I'm trying to properly close #54958 and sebastiaanvisser/clay#184.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 10, 2019
@cdepillabout cdepillabout merged commit fd71298 into NixOS:haskell-updates Dec 11, 2019
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Dec 11, 2019

Thanks! This should be available when #75429 is merged.

@turion turion deleted the haskell-updates branch December 11, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turion @cdepillabout