Skip to content

buildBazelPackage: also set the SSL_CERT_FILE environment variable#74536

Merged
flokli merged 1 commit intoNixOS:masterfrom
andrew-d:andrew/bazel-ssl-certs
Nov 28, 2019
Merged

buildBazelPackage: also set the SSL_CERT_FILE environment variable#74536
flokli merged 1 commit intoNixOS:masterfrom
andrew-d:andrew/bazel-ssl-certs

Conversation

@andrew-d
Copy link
Copy Markdown
Contributor

Motivation for this change

Bazel repository rules can run arbitrary code to fetch sources, which may require our SSL certificate file. Set this in the builder, instead of each individual package.

Extracted from #73097

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli

@andrew-d andrew-d mentioned this pull request Nov 28, 2019
10 tasks
@flokli flokli merged commit 8253c10 into NixOS:master Nov 28, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 28, 2019
@andrew-d andrew-d deleted the andrew/bazel-ssl-certs branch November 28, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants