krohnkite: init at 0.5 #74262
Merged
krohnkite: init at 0.5 #74262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: qt/kde
8.has: package (new)
jonringer
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
fails during install
building '/nix/store/wm5pjr3qhppacvjq4y3xjblqbz3la933-krohnkite-0.5.drv'...
unpacking sources
unpacking source archive /nix/store/9i2chn7id4hjj290x0cycfk31wzb5s89-source
source root is source
patching sources
configuring
no configure script, doing nothing
glibPreInstallPhase
installing
Error: Installation of /nix/store/9i2chn7id4hjj290x0cycfk31wzb5s89-source failed: No metadata file in package: /nix/store/9i2chn7id4hjj290x0cycfk31wzb5s89-source
builder for '/nix/store/wm5pjr3qhppacvjq4y3xjblqbz3la933-krohnkite-0.5.drv' failed with exit code 4
|
Hmm just realized nix-shell didn't call the install phase, now it should install at least. But there is still an issue I can't understand though.. I copied the "solution" from other kwin script in the tree (only example), but plugin still complains about Maybe installing over home-manager puts some wrong library paths.. |
jonringer
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM (although, im not familiar with this installation process)
no idea how to test
[3 built, 232 copied (617.9 MiB), 144.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74262
1 package were built:
krohnkite
ttuegel
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
krohnkite is a kwin script which supplies dwm-style tiling
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @