Skip to content

java classpath hook: allow unbound $CLASSPATH#74093

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
eraserhd:java-classpath-fix
Nov 25, 2019
Merged

java classpath hook: allow unbound $CLASSPATH#74093
Ericson2314 merged 1 commit intoNixOS:masterfrom
eraserhd:java-classpath-fix

Conversation

@eraserhd
Copy link
Contributor

Motivation for this change

Started getting CLASSPATH: unbound from this hook after updating master a couple hours ago, and it seems to be related to #72347.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ericson2314

This seems to cause rebuilds of JVMs, unforunately; but we can't build Java/Graal packages anymore without it.

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 25, 2019
@Ericson2314
Copy link
Member

Thanks!

@Ericson2314 Ericson2314 merged commit aa7c021 into NixOS:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants