Skip to content

applgrid: fix build#74092

Merged
matthewbauer merged 2 commits intoNixOS:masterfrom
veprbl:pr/applgrid_fix
Nov 26, 2019
Merged

applgrid: fix build#74092
matthewbauer merged 2 commits intoNixOS:masterfrom
veprbl:pr/applgrid_fix

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 25, 2019 •
edited
Loading

Motivation for this change

First issue caused by #72347 (cc @Ericson2314)
Second issue happened after #70515 (cc @peti)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 25, 2019
@matthewbauer matthewbauer merged commit e010c1b into NixOS:master Nov 26, 2019
@veprbl veprbl deleted the pr/applgrid_fix branch December 1, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veprbl @matthewbauer