buildBazelPackage: allow specifying whether to remove rules_cc#74013
Merged
Profpatsch merged 1 commit intoNixOS:masterfrom Nov 27, 2019
Merged
buildBazelPackage: allow specifying whether to remove rules_cc#74013Profpatsch merged 1 commit intoNixOS:masterfrom
Profpatsch merged 1 commit intoNixOS:masterfrom
Conversation
Profpatsch
reviewed
Nov 26, 2019
97cc32e to
8b82596
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Newer versions of Bazel are moving away from built-in
rules_ccand instead allow fetching it as an external dependency in aWORKSPACEfile. If removed in the fixed-output fetch phase, building will fail to download it. This can be seen e.g. in #73097.The new
rules_cclive here, which say:This PR changes things to allow disabling removing
rules_ccwith a flag tobuildBazelPackage, set totrueby default to replicate the behavior today. Additionally, this only affects thedepsderivations, which are fixed-output, and thus shouldn't affect any packages today.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @abbradar @Profpatsch