Skip to content

buildBazelPackage: allow specifying whether to remove rules_cc#74013

Merged
Profpatsch merged 1 commit intoNixOS:masterfrom
andrew-d:andrew/dont-remove-rules_cc
Nov 27, 2019
Merged

buildBazelPackage: allow specifying whether to remove rules_cc#74013
Profpatsch merged 1 commit intoNixOS:masterfrom
andrew-d:andrew/dont-remove-rules_cc

Conversation

@andrew-d
Copy link
Copy Markdown
Contributor

Motivation for this change

Newer versions of Bazel are moving away from built-in rules_cc and instead allow fetching it as an external dependency in a WORKSPACE file. If removed in the fixed-output fetch phase, building will fail to download it. This can be seen e.g. in #73097.

The new rules_cc live here, which say:

The rules are being incrementally converted from their native implementations in the Bazel source tree.

This PR changes things to allow disabling removing rules_cc with a flag to buildBazelPackage, set to true by default to replicate the behavior today. Additionally, this only affects the deps derivations, which are fixed-output, and thus shouldn't affect any packages today.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar @Profpatsch

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 24, 2019
@andrew-d andrew-d mentioned this pull request Nov 25, 2019
10 tasks
@andrew-d andrew-d force-pushed the andrew/dont-remove-rules_cc branch from 97cc32e to 8b82596 Compare November 27, 2019 05:24
Copy link
Copy Markdown
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@Profpatsch Profpatsch merged commit 3f86f21 into NixOS:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants