Skip to content

Haskell snap#74

Merged
peti merged 8 commits intoNixOS:masterfrom
aforemny:haskell-snap
Aug 3, 2012
Merged

Haskell snap#74
peti merged 8 commits intoNixOS:masterfrom
aforemny:haskell-snap

Conversation

@aforemny
Copy link
Contributor

Add haskell-snap package with dependencies.

As it turned out haskell-snap and dependencies are already in master and I just didn't noticed that. But I cannot build haskell-snap-ghc7.4.1 from master. This is fixed in my haskell-snap branch by adding some older packages as dependencies. Testing done: haskell-snap-ghc7.4.1 built locally.

Alexander Foremny added 7 commits July 24, 2012 00:41
configure fails while trying to lookup the sonames of some libraries.
comonad-1.1.1.6
comonad-3.0.0.1
configurator-0.2.0.0
contravariant-0.2.0.2
data-lens-2.10.1
data-lens-template-2.1.5
distributive-0.2.2
heist-0.8.1.1
semigroupoids-1.3.4
snap-0.9.1.1
xmlhtml-0.2.0.0
Conflicts:
	pkgs/development/libraries/haskell/comonad-transformers/default.nix
	pkgs/development/libraries/haskell/semigroupoids/default.nix
	pkgs/top-level/haskell-packages.nix
@peti
Copy link
Member

peti commented Aug 1, 2012

Please don't mix default.nix and version-number.nix files in the same directory. If a package is provided in more than one version, then all related files should use the version-number-style file name. Similarly, the attribute names in haskell-packages.nix should be consistent, i.e. there should be one package_x_y_z attribute per version, and one package = self.package_x_y_z attribute that redirects to the latest (or most stable) version that other packages should refer to by default.

@peti
Copy link
Member

peti commented Aug 1, 2012

Also, I don't understand why this pull request contains a patch that removes autoconf 2.67? That seems unrelated?

@aforemny
Copy link
Contributor Author

aforemny commented Aug 1, 2012

@peti Yes, the first three commits are unrelated to this pull request. I accidentally created a new branch from my XBMC branch instead of master. The last commit removes those unrelated commits, however. Sorry for the noise in the commit log.

@peti
Copy link
Member

peti commented Aug 3, 2012

@aforemny, are you planning to address the points I've mentioned?

@aforemny
Copy link
Contributor Author

aforemny commented Aug 3, 2012

@peti, you suggested a different naming convention for both files and attributes. See commit 8ea5b1a. Further, you asked about the commit history. I commented on this in the pull request. What else is to be done? I am sorry if the commit
8ea5b1a is not properly included. I am not that familiar with Git. Also, I can clean up the commit history if necessary.

peti added a commit that referenced this pull request Aug 3, 2012
@peti peti merged commit 1e0b1b2 into NixOS:master Aug 3, 2012
@peti
Copy link
Member

peti commented Aug 3, 2012

Sorry, I didn't see your last commit. I assumed Github would notify me when the pull request changes, but apparently it didn't. Anyway, your changes are now merged to master. Thank you!

wkennington pushed a commit to wkennington/nixpkgs that referenced this pull request Sep 29, 2016
@veprbl veprbl mentioned this pull request May 31, 2020
10 tasks
ethancedwards8 pushed a commit to ethancedwards8/nixpkgs that referenced this pull request Apr 2, 2021
modulitos pushed a commit to modulitos/nixpkgs that referenced this pull request Nov 24, 2024
notklea pushed a commit to notklea/nixpkgs that referenced this pull request Dec 1, 2025
Update charybdis ircv3.2 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants