Skip to content

python3Minimal: 3.7.4 -> 3.7.5 #73824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FRidh merged 1 commit into from
Nov 21, 2019
Merged

python3Minimal: 3.7.4 -> 3.7.5 #73824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions pkgs/development/interpreters/python/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ with pkgs;
inherit hasDistutilsCxxPatch pythonForBuild;
};

in {
in rec {
Copy link
Contributor

@lopsided98 lopsided98 Dec 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this rec added? It doesn't seem to be necessary and breaks overriding/adding packages in the Python package set in an overlay using packageOverrides. The overrides do not end up applied to python3Packages.python.pkgs.

Copy link
Member

@flokli flokli Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @FRidh

Copy link
Member Author

@FRidh FRidh Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed rec in 92d2153. If overriding is broken, show it with an example.

Copy link
Contributor

@lopsided98 lopsided98 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that fixes it.


python27 = callPackage ./cpython/2.7 {
self = python27;
Expand Down Expand Up @@ -127,18 +127,8 @@ in {
};

# Minimal versions of Python (built without optional dependencies)
python3Minimal = (callPackage ./cpython {
python3Minimal = (python37.override {
self = python3Minimal;
sourceVersion = {
major = "3";
minor = "7";
patch = "4";
suffix = "";
};
sha256 = "0gxiv5617zd7dnqm5k9r4q2188lk327nf9jznwq9j6b8p0s92ygv";
inherit (darwin) CF configd;
inherit passthruFun;

# strip down that python version as much as possible
openssl = null;
readline = null;
Expand Down