darwin.CF: workaround intermittent CFRuntime.c failures#73572
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Nov 18, 2019
Merged
darwin.CF: workaround intermittent CFRuntime.c failures#73572vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
Based on testing this issue seems to only occur with clang_7, so we should be able to revert this when the default llvm versions are updated. Fixes NixOS#66811
ofborg
bot
added
6.topic: darwin
Member
|
Should this also revert #73501? |
Member
|
That one was never merged. |
vcunat
approved these changes
Nov 18, 2019
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
OK, let's do this hack for now; re-running ninja should be a very low overhead compared to restarting all the jobs on Hydra. Perhaps we can follow-up soon with llvm update.
vcunat
added a commit
that referenced
this pull request
Nov 18, 2019
... into staging-next. Fixes #66811, kinda.
Member
|
Now it succeeded on the first attempt 🤷♀️ |
Member
|
That's good news! |
Member
Author
|
Yeah. I'm looking into updating the stdenv and bootstrap-tools to llvm_9, but that will probably be a longer term project and won't be something we can pull into 19.09. |
Member
|
Right, I planned to use this in 19.09 as soon as the problem is encountered in there again. (There's probably not much sense to apply it "in advance".) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on testing this issue seems to only occur with clang_7, so
we should be able to revert this when the default llvm versions are
updated.
Fixes #66811
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @NixOS/darwin-maintainers @vcunat @FRidh