Skip to content

[19.09] profiles/graphical.nix: Drop systemWide pulseaudio in iso#73359

Merged
adisbladis merged 1 commit intoNixOS:release-19.09from
etu:1909-disable-systemwide-pulse-iso
Nov 13, 2019
Merged

[19.09] profiles/graphical.nix: Drop systemWide pulseaudio in iso#73359
adisbladis merged 1 commit intoNixOS:release-19.09from
etu:1909-disable-systemwide-pulse-iso

Conversation

@etu
Copy link
Contributor

@etu etu commented Nov 13, 2019

Motivation for this change

This is a follow-up on #73232

(cherry picked from commit 4403cd1)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis @worldofpeace

It's not needed since NixOS#66338 and should have been done earlier.

This is based on a follow-up on NixOS#56167.

(cherry picked from commit 4403cd1)
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 13, 2019
@adisbladis adisbladis merged commit 7cf3959 into NixOS:release-19.09 Nov 13, 2019
@etu etu deleted the 1909-disable-systemwide-pulse-iso branch November 14, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants