Skip to content

MinGW: Enable C++ threads with mcfgthreads for 19.09#73265

Merged
Ericson2314 merged 10 commits intoNixOS:release-19.09from
Ericson2314:mingw-mcfthreads
Nov 12, 2019
Merged

MinGW: Enable C++ threads with mcfgthreads for 19.09#73265
Ericson2314 merged 10 commits intoNixOS:release-19.09from
Ericson2314:mingw-mcfthreads

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 12, 2019

Motivation for this change

Backport of #73195

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
fetchurl: Eliminate pointless cross differences
38ebb8f
@Ericson2314
lib: Switch to w64 vendor for MinGW
9171853 
It is needed for the `-municode` flag, supposedly.
@Ericson2314
windows top-level: Clean up with makeScope
0a63190
@Ericson2314
mcfgthreads: Init from git
06c5e81
@Ericson2314
mingw-w64 libc: Multiple outputs and parallel builds
999ef20 
Also deduplicate more of the GCC derivations.
@Ericson2314
gcc: Build MinGW stage two with threading library
04cb05d 
Currently this is set up to be mcfgthreads, but it could be something
else instead.
@Ericson2314
pcre: Skip winpthread dep
89ec69e 
Seems to build just fine without it, maybe it was just using C++ threads
which mcfgthread provides?
@Ericson2314
boehm-gc: Fix build on MinGW with mcfgthreads
e00237e 
CC @lhmouse
@Ericson2314
openssl: Switch deafult for MinGW
dec8d2c 
Working around broken build for now.
@Ericson2314
nghttp2: Fix MinGW build by skipping some optional deps
63eac67 
I think those deps could be made to build, but I didn't want to get
bogged down investigating further. "Use flags" are always a good thing,
so this is fine for now.
@ofborg ofborg bot added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Nov 12, 2019
@Ericson2314 Ericson2314 mentioned this pull request Nov 12, 2019
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 12, 2019
@Ericson2314 Ericson2314 merged commit ef8c34c into NixOS:release-19.09 Nov 12, 2019
@bgamari bgamari mentioned this pull request Nov 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees

No one assigned

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Ericson2314