Skip to content

cc-wrapper, bintools-wrapper: Remove now unneeded set {+,-}u#72812

Merged
Ericson2314 merged 18 commits intostagingfrom
bash-no-undef-vars
Nov 8, 2019
Merged

cc-wrapper, bintools-wrapper: Remove now unneeded set {+,-}u#72812
Ericson2314 merged 18 commits intostagingfrom
bash-no-undef-vars

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 5, 2019 •
edited
Loading

Motivation for this change

I noticed late in #72347 that I missed a few in the wrappers. This could cause more breakage since the set +u now "leaks" with out the stdenv cleanup, so I figured rather than last-minute add to the last PR, I'd make another.

https://hydra.nixos.org/jobset/nixpkgs/bash-no-undef-vars

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 5, 2019
matthewbauer
matthewbauer reviewed Nov 5, 2019
View reviewed changes
@Ericson2314 Ericson2314 mentioned this pull request Nov 5, 2019
Merged
2 tasks
@ofborg ofborg bot requested a review from magnetophon November 5, 2019 20:37
@ofborg ofborg bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label Nov 6, 2019
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 7, 2019
jtojnar
jtojnar reviewed Nov 7, 2019
View reviewed changes
jtojnar
jtojnar reviewed Nov 7, 2019
View reviewed changes
@Ericson2314 Ericson2314 requested a review from ttuegel as a code owner November 8, 2019 00:40
@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: qt/kde Object-oriented framework for GUI creation labels Nov 8, 2019
@Ericson2314
Copy link
Member Author

Ericson2314 commented Nov 8, 2019

OK, basically all the Darwin errors are due to unreated python and swift problems, and I just fixes the last linux errors I see, so I think this is ready for staging. I'll just watch staging if any darwin problems get uncovered.

@matthewbauer
Copy link
Member

matthewbauer commented Nov 8, 2019

Yeah that sounds good

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 8, 2019
@Ericson2314 Ericson2314 changed the base branch from staging to master November 8, 2019 19:13
@Ericson2314 Ericson2314 changed the base branch from master to staging November 8, 2019 19:14
@Ericson2314 Ericson2314 merged commit 5132cc8 into staging Nov 8, 2019
@Ericson2314 Ericson2314 deleted the bash-no-undef-vars branch November 8, 2019 20:26
@Ericson2314 Ericson2314 restored the bash-no-undef-vars branch November 8, 2019 20:26
@Ericson2314 Ericson2314 deleted the bash-no-undef-vars branch November 8, 2019 20:31
@sergv sergv mentioned this pull request Sep 10, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@magnetophon magnetophon Awaiting requested review from magnetophon

@ttuegel ttuegel Awaiting requested review from ttuegel

@alyssais alyssais Awaiting requested review from alyssais

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@zimbatm zimbatm Awaiting requested review from zimbatm

+1 more reviewer

@matthewbauer matthewbauer matthewbauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: emacs Text editor 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: stdenv Standard environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @matthewbauer @jtojnar