Skip to content

lib: Add lib.maintainer-groups #72125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtojnar merged 2 commits into from
Mar 10, 2020
Merged

lib: Add lib.maintainer-groups #72125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ac558
lib: Add lib.teams
jtojnar Oct 27, 2019
03941c1
colord: add freedesktop team to maintainers
jtojnar Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ let
# packaging
customisation = callLibs ./customisation.nix;
maintainers = import ../maintainers/maintainer-list.nix;
teams = callLibs ../maintainers/team-list.nix;
meta = callLibs ./meta.nix;
sources = callLibs ./sources.nix;
versions = callLibs ./versions.nix;
Expand Down
24 changes: 24 additions & 0 deletions maintainers/team-list.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/* List of maintainer teams.
name = {
# Required
members = [ maintainer1 maintainer2 ];
scope = "Maintain foo packages.";
};

where

- `members` is the list of maintainers belonging to the group,
- `scope` describes the scope of the group.
Copy link
Member

@grahamc grahamc Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `scope` describes the scope of the group.
- `scope` describes the scope of the group,
- `type` "interest-group" or "business",
- `membership` "open" or "closed"; to join a closed group, existing members must approve.

Copy link
Member Author

@jtojnar jtojnar Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

Copy link
Member Author

@jtojnar jtojnar Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant IRC discussion https://logs.nix.samueldr.com/nixos-dev/2020-03-09#1583795904-1583796772;


More fields may be added in the future.

Please keep the list alphabetically sorted.
*/

{ lib }:
with lib.maintainers; {
freedesktop = {
members = [ jtojnar worldofpeace ];
scope = "Maintain Freedesktop.org packages for graphical desktop.";
};
}
2 changes: 1 addition & 1 deletion pkgs/tools/misc/colord/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ stdenv.mkDerivation rec {
description = "System service to manage, install and generate color profiles to accurately color manage input and output devices";
homepage = https://www.freedesktop.org/software/colord/;
license = licenses.lgpl2Plus;
maintainers = [ maintainers.marcweber ];
maintainers = [ maintainers.marcweber ] ++ teams.freedesktop.members;
platforms = platforms.linux;
};
}