Skip to content

hdf5: don't force GCC 7#72124

Merged
veprbl merged 1 commit intoNixOS:masterfrom
lopsided98:hdf5-gcc7
Oct 28, 2019
Merged

hdf5: don't force GCC 7#72124
veprbl merged 1 commit intoNixOS:masterfrom
lopsided98:hdf5-gcc7

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Oct 27, 2019

Motivation for this change

HDF5 seems to build fine with GCC 8 now and I don't like building extra GCCs on my ARM machines. See #40704 for when the GCC 7 override was added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Synthetica9

@lopsided98
Copy link
Contributor Author

lopsided98 commented Oct 27, 2019

@GrahamcOfBorg build hdf5

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 27, 2019
veprbl
veprbl approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on darwin too.

@veprbl veprbl merged commit d448421 into NixOS:master Oct 28, 2019
@lopsided98 lopsided98 deleted the hdf5-gcc7 branch November 5, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lopsided98 @veprbl