R: Add enableShared/enableStatic arguments#72058
Merged
peti merged 1 commit intoNixOS:masterfrom Oct 30, 2019
Merged
Conversation
Contributor
Author
|
@GrahamcOfBorg eval R |
peti
reviewed
Oct 30, 2019
Member
peti
left a comment
There was a problem hiding this comment.
Just out of curiosity: why would you want to link R packages statically?
Contributor
Author
Linking the R interpreter library statically would allow to create single binaries that can interpret R scripts. My own end goal for that is to be able to link the Haskell packages |
R's autoconf does not use the normal configure flags for that.
Contributor
Author
|
@GrahamcOfBorg build R |
Contributor
Author
|
@peti Points addressed, please have another look :) |
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Building
libR.afor static linking.Care was taken to not modify the derivation to trigger mass rebuilds with the default arguments.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @peti @timokau