Skip to content

postgresql: Disable 2 failing tests on musl#72019

Merged
nh2 merged 1 commit intoNixOS:masterfrom
nh2:postgres-musl-test-failures
Oct 30, 2019
Merged

postgresql: Disable 2 failing tests on musl#72019
nh2 merged 1 commit intoNixOS:masterfrom
nh2:postgres-musl-test-failures

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Oct 26, 2019

Motivation for this change

Make postgres tests not break build on musl.

See here from Alpine:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ocharles @thoughtpolice @danbst @globin

cc @matthewbauer

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 26, 2019
@nh2 nh2 force-pushed the postgres-musl-test-failures branch from b4c147c to 09ffd72 Compare October 30, 2019 12:27
@nh2 nh2 merged commit 765c0e0 into NixOS:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants