Skip to content

nodePackages.purescript-language-server: init at 0.12.7#71215

Closed
justinlovinger wants to merge 3 commits intoNixOS:masterfrom
justinlovinger:purescript-language-server
Closed

nodePackages.purescript-language-server: init at 0.12.7#71215
justinlovinger wants to merge 3 commits intoNixOS:masterfrom
justinlovinger:purescript-language-server

Conversation

@justinlovinger
Copy link
Contributor

@justinlovinger justinlovinger commented Oct 16, 2019

Motivation for this change

Add purescript-language-server. Required for language server clients like coc.nvim to work with PureScript.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 16, 2019
@adisbladis adisbladis self-assigned this Oct 18, 2019
@veprbl veprbl requested review from Amar1729 and marsam and removed request for Amar1729 February 9, 2020 23:14
@veprbl veprbl added 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Feb 9, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@NickHu
Copy link
Contributor

NickHu commented Jun 28, 2020

Whoops, I believe this is superseded by #91438 (I should've looked before making a PR). I'll close this now.

@NickHu NickHu closed this Jun 28, 2020
@justinlovinger
Copy link
Contributor Author

justinlovinger commented Jun 30, 2020

@NickHu No problem :) I'm just glad it's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@marsam marsam Awaiting requested review from marsam

Assignees

@adisbladis adisbladis

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinlovinger @prusnak @NickHu @adisbladis @veprbl